light.needRefreshPerFrame() seems broken

[meteoritool]

Hi,

It's all in the title ! As for now, light.needRefreshPerFrame() seems broken :

http://www.babylonjs-playground.com/#1ITHGT#1

light0.needRefreshPerFrame is not a function. (In 'light0.needRefreshPerFrame(false)', 'light0.needRefreshPerFrame' is undefined)

[GameMonetize]

Perhaps because it is NOT a function

http://www.babylonjs-playground.com/#1ITHGT#2

 

[meteoritool]

 

I might have got wrong the documentation, but before last update, there was no error in my script, now it doesn't work anymore, but I had it written as a function with no error with previous versions ...

 

[GameMonetize]

Good catch!

This is @Sebavan fault  he broke the compat with his last change.

@Sebavan: Do you mind reverting it to a method?

[Sebavan]

Hello,

This method was not taking any params and Here is why it has been removed: https://github.com/BabylonJS/Babylon.js/blob/087e898e334957ce17ecb0129d1da5c8459354b5/src/Lights/babylon.directionalLight.ts#L142

This was simply returning an hard coded boolean and not intented to be called but to allow external people to create their own light/shadow system. 

I am not for reverting this one :-) as it just adds code which does nothing.

This was also forcing the shadows matrix to refresh on every frame despite the position or direction cached in the light so basically removing it makes it also more performant.

@Deltakosh @meteoritool any thought ?

[GameMonetize]

Makes sense..Let's keep it like this. THis is fine