SvenFrankson

AbsoluteRotation and AbsoluteRotationQuaternion

Recommended Posts

Hi,

We have a project where there's a need to get absoluteRotation and / or absoluteRotationQuaternion.

Is there a need somewhere so a pull request about this is possible ?

If so, is it wise to compute it here 

https://github.com/BabylonJS/Babylon.js/blob/88145e1d19e13c88afd09c63a474d0af15e0d7a1/src/Mesh/babylon.abstractMesh.ts#L1312

By adding _absoluteRotation and _absoluteRotationQuaternion private properties and

this._worldMatrix.getRotationMatrixToRef(Tmp.Matrix[0]);
BABYLON.Quaternion.FromRotationMatrixToRef(Tmp.Matrix[0], this._absoluteRotationQuaternion);
if (!this.rotationQuaternion) {
    this._absoluteRotationQuaternion.toEulerAnglesToRef(this._absoluteRotation);
}

Or should it be only done in a getAbsoluteRotation method to avoid the overhead of computing it every time computeWorldMatrix is invoked ?

(note : what's the usage for this kind of question ? using the forum, GitHub issues or directly submitting a PR on GitHub ?)

Thanks a lot and have a nice day !

Share this post


Link to post
Share on other sites

(regarding github: we keep it ONLY for bugs and for me to track what the roadmap is)

I like this idea but we cannot have it in the computeWorldMatrix. So yes a on demand property could be cool here! This property can be smart and have a dirty flag to update it only when computeWM was called

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.