solved TypeScript 3.0.1 Compiler Issue

[Christopher Stock]

Please pardon me announcing this issue with the latest Major of TypeScript:

Error:(6474, 5) TS2717: Subsequent property declarations must have the same type.  Property 'leftBounds' must be of type 'number[] | Float32Array', but here has type 'number[]'.
Error:(6475, 5) TS2717: Subsequent property declarations must have the same type.  Property 'rightBounds' must be of type 'number[] | Float32Array', but here has type 'number[]'.

This issue can be fixed by extendig the Type Definition for the class VRLayer in the following way:

interface VRLayer {
    leftBounds?: number[] | Float32Array | null;
    rightBounds?: number[] | Float32Array | null;
    source?: HTMLCanvasElement | null;
}

Keep up your great work and don't fight the feeling!  ❤️ ❤️

Sincerely yours
Christopher 

[Guest]

hello and welcome!

 

fancy doing a PR? 

[Christopher Stock]

Hi @Deltakosh

I've forked your project on GitHub and noticed, that the project is running with TypeScript version 2.8.1 so the mentioned compiler errors do not appear yet.

Anyway -- I created a PR where the TypeScript version has been updated to the latest version 3.0.1 and fixed the mentioned compiler errors.
https://github.com/BabylonJS/Babylon.js/pull/4885

Your company did a great job and this was the only breaking change in your project that came with the new major.

Keep up the good work and have a nice weekend, dear David!

Sincerely
Christopher

[Guest]

Thanks Christopher! But so far the unit tests are failing with your change

[Christopher Stock]

Oh .. my bad -- ?

I'd love to fix the tests but the Karma Test Runner couldn't find any Tests in

https://github.com/BabylonJS/Babylon.js/tree/master/
or
https://github.com/BabylonJS/Babylon.js/tree/master/tests/unit

on running

npm test

Can you give me an advice please?

Thanks & Greetings
Christopher

[Guest]

so to make sure everything run, go to tools/gulp, run npm install and start gulp

it will go through the entire process for you

[Christopher Stock]

I managed to update the subprojects to TypeScript 3.0.1 and fixed some type errors that occurred on test run via gulp..
I'll get back to you, when all Builds and Tests run flawless and the PR is ready.

[Guest]

Merged! thanks a lot!