phaselock

Pointerup observable bug ?

Recommended Posts

Well, my codes were working fine yesterday, this morning something went awry with my pointer observables. Dug a little into it and found similar reproducible results in https://doc.babylonjs.com/how_to/interactions . The playground example (https://www.babylonjs-playground.com/#0XYMA9#1) is working fine for the stable version, when I switch to latest version, clicking on the sphere or plane no longer triggers the pointerup event until I doubleclick. Consistent in the console log as well.

Share this post


Link to post
Share on other sites

Hello All,

yeah... this got introduced yesterday when we were trying to resolve - 

 

It's because introduction of this new variable -

https://github.com/BabylonJS/Babylon.js/commit/9cc8c3e7a3a4c3e4d54f07a853acf6ca05ff1023#r30796147

Will make a new PR after testing thoroughly :) 

Meanwhile happy weekend ! My brain's bursting out ! The pointer events are too complicated :D 

Share this post


Link to post
Share on other sites

@TomaszFurca
Looks like the pointerUp event is 'counted' as a pointerMove.

> Observers still work, only scene.onPointerUp seems to be affected.
> clickInfo.ignore is always true. (should be false for onPointerUp..) http://playground.babylonjs.com/#UM43F8#1

 

@Deltakosh
I have to run so i'll tag this for you.

scene -> attachControl ->  _initClickEvent -> always sets "clickInfo.ignore = true" before callback is called.
See line 177 -> http://playground.babylonjs.com/#UM43F8#5
( commented it out, and onPointerUp works again )

Is there a reason for that to be there`? 

Share this post


Link to post
Share on other sites

ok, this is a weird bug....finally got the repro. https://www.babylonjs-playground.com/index.html#0XYMA9#2

Open the console and play with this:

a) click in the PG canvas, console should throw 2 counts of pointer up events.

b) Comment out camera.attachControl FOR the arc rotate camera, click run, click in canvas, console now throws 1 count of pointer up event.

c) Comment out var camera = new BABYLON.ArcRotateCamera..., uncomment the 2 lines on freecamera, click run, click in canvas, console throws 1 count of pointer up event.

So, it would seem like attach control for arc rotate camera is the bug....weird right ?

Share this post


Link to post
Share on other sites

FYI
Playground http://www.babylonjs-playground.com/#7RH606 from https://doc.babylonjs.com/how_to/gui probably has same error.
When you click the button it doesn't count (call the onPointerClickObservable).

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now

  • Recently Browsing   0 members

    No registered users viewing this page.