Inspector v2.0 is ready for testing

[Guest]

bug..but in the engine

See the inspector is a wonderful tool !!

[rpajo]

Hey.

 

I use the inspector constantly when developing scene. Love the new update but I can't seem to find the properties on for example PRB materials (roughness, metallic, ...).

Is this planed or is it just me not finding it? ?

[Guest]

They are all here (this is for a general PBRMaterial)

 

[rpajo]

Don't know where i was looking. ? Thanks.

One thing i have noticed when using the Sandbox is, that the inspector windnow closes when clicking on a texture in the scene explorer and doesn't reopen unit i re-toggle the inspector. The playground inspector works as expected though.

[Guest]

Can you share the scene you were using when that happened? This is a bug I think

[rpajo]

I have tested with some of my models and with multiple scenes from the https://github.com/KhronosGroup/glTF-Sample-Models repository so it may not be scene specific.

The error from the minified bundle is thrown from the render() function in texturePropertyGridComponent.tsx .

I will try to inspect it further.

[Guest]

or just share the model you used and the texture you tried to inspect

[rpajo]

Here is one tested scene: https://1drv.ms/u/s!AmJWLwEI5fMPoD7PIoj7Z043GxGf

The issue occurs for every clicked texture in the scene.

[acarvallo]

Hello,

I recently updated to BabylonJS v4.0.0-alpha.9 and the new Inspector/Debug Layer doesn't work for me, I'm calling "scene.debugLayer.show()" and I get "Uncaught TypeError: Cannot read property 'Inspector' of undefined" after it loads the script because it's trying to call isVisible() but this.BJSINSPECTOR is undefined at that time:

 

[V!nc3r]

If you specify the url, is this still happen ?

example:

BABYLON.DebugLayer.InspectorURL = 'https://preview.babylonjs.com/inspector/babylon.inspector.bundle.js';

 

[servusdei]

There's no error for me; But nothing is showing. 

babylon.inspector.bundle.js is loaded using :

scene.debugLayer.show();

[Sebavan]

Can you reproduce the issue in the playground or a test page ?

it would be easier to debug.

[acarvallo]

8 minutes ago, Sebavan said:

Can you reproduce the issue in the playground or a test page ?

it would be easier to debug.

Well, I can't since the inspector is loaded by default in one of the <script> tag of the playground page.

 

34 minutes ago, V!nc3r said:

If you specify the url, is this still happen ?

example:

BABYLON.DebugLayer.InspectorURL = 'https://preview.babylonjs.com/inspector/babylon.inspector.bundle.js';

 

You can see at the bottom of the screenshot that the URL is already here, the error appears after loading the script, URL is fine

[Sebavan]

Do you happen to have an online accessible version or a repro we could use ?

[servusdei]

25 minutes ago, servusdei said:

There's no error for me; But nothing is showing. 

babylon.inspector.bundle.js is loaded using :

scene.debugLayer.show();

 

I updated Babylon.js and now I'm having :

babylon.js:1 Uncaught TypeError: Cannot read property 'Inspector' of undefined
    at t.isVisible (babylon.js:1)
    at t._createInspector (babylon.js:1)
    at HTMLScriptElement.n.onload (babylon.js:1)

 

 

[servusdei]

5 minutes ago, servusdei said:

 

I updated Babylon.js and now I'm having :

babylon.js:1 Uncaught TypeError: Cannot read property 'Inspector' of undefined
    at t.isVisible (babylon.js:1)
    at t._createInspector (babylon.js:1)
    at HTMLScriptElement.n.onload (babylon.js:1)

 

 

OK, I loaded directly and it worked; 

<script src="https://preview.babylonjs.com/inspector/babylon.inspector.bundle.js"></script>

 

 

[Sebavan]

It looks like the namespace is not defined for some reason.

Are you using any bundling tools or loaders ? and if so which ones ?

[servusdei]

2 minutes ago, Sebavan said:

It looks like the namespace is not defined for some reason.

Are you using any bundling tools or loaders ? and if so which ones ?

Not me, just a plain index.html with:

<script src="libs/pep.js"></script>

<script src="libs/babylon.js"></script>

<script src="libs/babylonjs.loaders.min.js"></script>

<script src="https://preview.babylonjs.com/inspector/babylon.inspector.bundle.js"></script>

[Sebavan]

Ok I ll giv it a try locally.

[acarvallo]

6 minutes ago, Sebavan said:

It looks like the namespace is not defined for some reason.

Are you using any bundling tools or loaders ? and if so which ones ?

I am using webpack 4, but it's not the reason behind the issue, see: https://codepen.io/anon/pen/ZmvEbV

(I just used the template https://doc.babylonjs.com/babylon101/first#html-template and called scene.debugLayer.show() )

[Sebavan]

I have a fix for it It will be up in 10 minutes. Thanks for reporting.

[Sebavan]

Deployed and fixed (at least on codepen ?)