Sign in to follow this  
JohnK

Before I PR to babylon.js need to check somethings

Recommended Posts

So I have forked and cloned babylon.js, added CreatePolygon to babylon.mesh.ts, babylon.mesh.vertexData.ts and babylon.meshBuilder.ts. Made a copy of this clone in a new folder (haven't fully got the hang of this branching thingy with git), done the Gulpy things and compiled to Javascript in the copy and the min file babylon.js seems to work OK with new functions. (will spend a bit more time fully testing tomorrow). Now a couple of questions as I am just blindly following contributing instructions and trying to convert my original Javascript code to acceptable typescript by reading the code that is already there..

1. Some things like Box and Cylinder and Sphere appear in babylon.geometry.ts with a

export class SHAPE extends _Primitive

type whatsit. Do I need to make changes here as well? Not sure what the geometry bits are for.

2. Do I PR the version that I have not compiled from Typescript to Javascript or do I PR the compiled version.

3. ( A couple means 3 or 4 doesn't it). Does somebody check I haven't messed things up before the PR is accepted?

 

 

Share this post


Link to post
Share on other sites

2: You commit the changed .ts files, and then you make a pull request from that commit

3: Yes. When I made a pull request, Deltakosh looked over the code, but I had to actually test it myself.

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Loading...
Sign in to follow this  

  • Recently Browsing   0 members

    No registered users viewing this page.