Jump to content

commit erased


Recommended Posts



the last BJS commit https://github.com/BabylonJS/Babylon.js/commit/534f87a3f70c5264310185aa4d34db6801f06ae8

just erased my former feature in CreateCylinder() in VertexData.ts (feature hasRings)  https://github.com/jbousquie/Babylon.js/commit/2b4f2feaa601c5ab5c51f6360c959472525c9a92


And I have no idea how to get this feature back as I can't re-PR my branch to the core.

Link to comment
Share on other sites

Noooo... I don't explain well


Check this please : https://github.com/BabylonJS/Babylon.js/commits/master


As you can see on merge #819 and 821, I made 2 changes in the file VertexData.ts : optimized the function ComputeNormals() and added a feature to CreateCylinder(), called hasRings.

These changes were correctly merged at this moment.


If you check the next DK's commit ("Fixing cache issue for computeWorldMatrix"), you'll see that the ComputeNormals() optimization is then removed from VertexData.ts but the CreateCylinder() hasRings feature is still inside as it were just added.


And the next commit then modifying the file VertexData.ts, called "Cleaning code for PBR" removes the hasRings feature.


So these two commits removed in turn what I PRed last friday.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Recently Browsing   0 members

    • No registered users viewing this page.
  • Create New...