dimous Posted June 26, 2016 Share Posted June 26, 2016 Hello! I'm logged in on github, but for some reason can't access "issues" tab, therefore I'm writing it here. Some private members became public, but still prefixed with underscore, for example - https://github.com/BabylonJS/Babylon.js/blob/master/src/babylon.engine.ts#L296. It's not that important, I know, but I'm cringing seeing this, lol. I belive, it's good to strictly follow code conventions. Thank you for attention. Quote Link to comment Share on other sites More sharing options...
GameMonetize Posted June 27, 2016 Share Posted June 27, 2016 Hello! this is on purpose as there is no "internal" keyword support on TypeScript Quote Link to comment Share on other sites More sharing options...
Kesshi Posted June 27, 2016 Share Posted June 27, 2016 2 hours ago, Deltakosh said: Hello! this is on purpose as there is no "internal" keyword support on TypeScript Actually there is. See the "--stripInternal" compiler option here: https://github.com/Microsoft/TypeScript-Handbook/blob/master/pages/Compiler%20Options.md I didn't tested it on propeties yet but i'm using it in my library to hide internal methods. They are not part of the .d.ts this way. But i also use the underscore prefix for public internal members. Quote Link to comment Share on other sites More sharing options...
GameMonetize Posted June 28, 2016 Share Posted June 28, 2016 Yep but it was not the case when we started the project Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.