solved Shader Material does not implement isReadyForSubMesh? [Updating to 3.2]

[gamefan]

Hi,

I am planning to update from 3.1 and was trying the latest preview. Some of my babylonjs files did not render because I checked that the shader material did not override isReadyForSubMesh and the base class's method always returned false. This made my app stuck here because the scene would never be ready:

scene.executeWhenReady(function() {
     engine.runRenderLoop(function() {
         scene.render();
       });

});

Please help.

[Guest]

This should not append as the engine check if material supports isReadyForSubMesh before calling it

Do you have a repro in the playground?

[gamefan]

Hi Deltakosh,

I should have done this earlier: https://www.babylonjs-playground.com/#D6VHKG#1
There is an alert that fires on scene ready. If you comment out the lines specified, executeWhenReady triggers the alert but not when shader material is applied to a submesh.

 

[Guest]

PERFECT!

Bug found and fixed with next commit

thanks a lot!

[gamefan]

No problem. I actually feel good I helped you