dotmaners Posted October 13, 2015 Share Posted October 13, 2015 This one is a quicky: it looks like phaser.d.ts and phaser.comments.d.ts are exactly the same besides the comments. Are the comments in phaser.comments.d.ts show up in TypeScript Intellisense? As such, does that mean that phaser.comments.d.ts is recommended over phaser.d.ts? If so, why would one use phaser.d.ts over phaser.comments.d.ts? Thanks!~dotMANERS Link to comment Share on other sites More sharing options...
rich Posted October 13, 2015 Share Posted October 13, 2015 Actually the grunt script that generates the comments file no longer runs, and I've no idea why (or any time to figure it out, as I didn't code the original), so I'll need to remove the comments defs from the next release (unless someone gets in there quick and can resolve it). Link to comment Share on other sites More sharing options...
dotmaners Posted October 13, 2015 Author Share Posted October 13, 2015 Actually the grunt script that generates the comments file no longer runs, and I've no idea why (or any time to figure it out, as I didn't code the original), so I'll need to remove the comments defs from the next release (unless someone gets in there quick and can resolve it). Thanks for the reply rich! Does this mean that the comments version is the preferred version, but is outdated now? Also, if you get a minute, could you point me in the direction of the piece of the grunt script in question? Link to comment Share on other sites More sharing options...
rich Posted October 13, 2015 Share Posted October 13, 2015 https://github.com/photonstorm/phaser/blob/master/tasks/buildtsdoc.js The one without the comments has to exist, because it's the base from which the one with comments is built from. Link to comment Share on other sites More sharing options...
mjohnsonengr Posted November 1, 2015 Share Posted November 1, 2015 @dotmaners, are you going to look into this? If not, I might. I really appreciate the commented version! Link to comment Share on other sites More sharing options...
vulvulune Posted November 3, 2015 Share Posted November 3, 2015 I have written the grunt task to generate the commented typescript file. I didn't know that now it fails. I will try to find a minute quickly to fix it. Link to comment Share on other sites More sharing options...
rich Posted November 3, 2015 Share Posted November 3, 2015 Yeah I've no idea why it now fails - it throws this really weird grunt error. I was working fine until a couple of versions ago. I suspect something in the TS defs is now killing it, but I've no idea what. Debugging it was a nightmare, so honestly I had to give up. Link to comment Share on other sites More sharing options...
vulvulune Posted November 9, 2015 Share Posted November 9, 2015 The TypeScript API has changed is not compatible with the script to generate the commented files. I've try to update the grunt task but there are a lot of changes, and I don't have time so I gave up. But if we set the version 1.4.1 in the package.json file, the task works well. I did a pull request with this change, and with the commented files updated.https://github.com/photonstorm/phaser/pull/2198 Link to comment Share on other sites More sharing options...
Recommended Posts