satguru Posted January 1, 2016 Share Posted January 1, 2016 Are there any plans to submit babylonjs TypeScript type definition file to DefinitelyTyped site http://definitelytyped.org/ ? Quote Link to comment Share on other sites More sharing options...
davrous Posted January 1, 2016 Share Posted January 1, 2016 Hi, This could be a good idea. But Babylon.js is written in Typescript. TS dev can just download the TS version of babylon.js on our github repo. Still, I'll see how to submit the d.ts of Babylon to this site.Thanks,David Quote Link to comment Share on other sites More sharing options...
satguru Posted January 1, 2016 Author Share Posted January 1, 2016 I should have explained why I was looking for BabylonJs Type Definition file at DefinitelyTyped site. I am a Java programmer and was looking for a way to program Babylonjs using Java. Recently a new project came out called JSweet http://www.jsweet.org/ .JSweet is a "Java -> TypeScript -> JavaScript" transpiler. Thanks to TypeScript definition file they are able to provide Java interfaces to thousands of JavaScript libraries.I think they have a nightly build cycle which pulls Type Definition files from DefinitelyTyped site and create corresponding Java interface libraries, Their recommendation for adding support for libraries not yet supported by JSweet is to contribute the library's TypeDefinition file to DefinitelyTyped site.See http://www.jsweet.org/faq/#What_should_I_do_to_use_a_JavaScript_library_that_is_not_currently_supported_by_JSweet Quote Link to comment Share on other sites More sharing options...
RaananW Posted January 2, 2016 Share Posted January 2, 2016 Hi! So, this was already in the making, I guess no one followed... The merge request was never merged - https://github.com/DefinitelyTyped/DefinitelyTyped/pull/5170 Quote Link to comment Share on other sites More sharing options...
satguru Posted January 4, 2016 Author Share Posted January 4, 2016 Hi, Looks like "QuantumInformation" submission failed or did not have the tests.Not sure how the test works.I am assuming the tests are to validated the type definitions and that probably makes sense if the type definitions were created manually.Given that BabylonJS itself is written in TypeScript and the TDs are auto generated (right?) maybe we do not really need rigorous testing.Maybe a dummy test file might suffice.Yes? RegardsSatguru Quote Link to comment Share on other sites More sharing options...
satguru Posted January 4, 2016 Author Share Posted January 4, 2016 Hi, I went ahead and created a PR for this. seehttps://github.com/DefinitelyTyped/DefinitelyTyped/pull/7489 Hope its ok. RegardsSatguru Quote Link to comment Share on other sites More sharing options...
satguru Posted January 5, 2016 Author Share Posted January 5, 2016 Hi, The PR got merged. The babylonjs type def file is in DefinitelyTyped now https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/babylonjs RegardsSatguru Jaskar and RaananW 2 Quote Link to comment Share on other sites More sharing options...
RaananW Posted January 5, 2016 Share Posted January 5, 2016 Awesome!Thanks a lot :-)I thought I'll do it "when I have the time" but this is practically "never". Quote Link to comment Share on other sites More sharing options...
satguru Posted January 11, 2016 Author Share Posted January 11, 2016 FYI Using the type file at DefintelyTyped, JSweet has generated a BabylonsJS Java interface library. Seehttp://www.jsweet.org/candies-snapshots/ Here are the javadocshttps://jsweet.org/apidocs/snapshots/org/jsweet/candies/babylonjs--babylon/2.2.2-SNAPSHOT/ Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.