[solved] PBRMaterial something wrong with bump-level?

[javalang]

Hi there,

I did some comparison between StandardMaterial and PBRMaterial and found an odd effect with the level of the bumpTexture : setting this level to one, both materials have near the same "bump-amplitude" but lowering this value to zero seems to have no effect on the PBRMaterial, see playground.

Any ideas, bug?

[Sebavan]

In the pbr material the normal map level is used to scale only the xy coordinates as it is defined in gltf and thanks to you I figured an issue in the scale code, the fix should be in soon but will still be different from the standard one so I will also add a parameter to help you scale bump like the standard material.

        vec3 map = texture2D(bumpSampler, uv).xyz;

        map.x = vNormalReoderParams.x + vNormalReoderParams.y * map.x;

        map.y = vNormalReoderParams.z + vNormalReoderParams.w * map.y;

 

        #ifdef NORMALXYSCALE

            map = normalize(map * vec3(vBumpInfos.y, vBumpInfos.y, 1.0));

        #endif

 

 

[Sebavan]

The fix will be available in the PG tomorrow.

[javalang]

@Sebavan Thank you very much , works well now.

The fix is in "src/Shaders/ShadersInclude/bumpFragmentFunctions.fx", right?

[Sebavan]

yup and bumpFragment.fx if I remember well :-)