royibernthal Posted October 5, 2017 Share Posted October 5, 2017 I'd like to do some PRs, but at the moment I'm unable to compile bjs source so I'm having a hard time testing my changes. I cloned bjs locally via GitHub, I'm trying to compile the root folder in vscode using tsc: Quote > Executing task: tsc -p "d:\GitHub\Babylon.js\src\tsconfig.json" < Collisions/babylon.collisionWorker.ts(264,17): error TS2304: Cannot find name 'importScripts'. Collisions/babylon.collisionWorker.ts(265,17): error TS2304: Cannot find name 'importScripts'. Collisions/babylon.collisionWorker.ts(266,17): error TS2304: Cannot find name 'importScripts'. The terminal process terminated with exit code: 1 Terminal will be reused by tasks, press any key to close it. When commenting these problematic lines and trying to compile again I see this: Quote > Executing task: tsc -p "d:\GitHub\Babylon.js\src\tsconfig.json" < Terminal will be reused by tasks, press any key to close it. No errors, but it seems like nothing is being compiled. What am I missing? Quote Link to comment Share on other sites More sharing options...
brianzinn Posted October 5, 2017 Share Posted October 5, 2017 I haven't compiled from source in a couple of weeks. What version of Typescript and what do you have in tsconfig for lib? (ie: ["es6", "dom"]). Quote Link to comment Share on other sites More sharing options...
royibernthal Posted October 5, 2017 Author Share Posted October 5, 2017 TypeScript 2.5.2. My tsconfig.json is exactly that: https://github.com/BabylonJS/Babylon.js/blob/master/src/tsconfig.json Quote Link to comment Share on other sites More sharing options...
Sebavan Posted October 6, 2017 Share Posted October 6, 2017 Hello, Can you not rely on the available gulp process ? http://doc.babylonjs.com/generals/how_to_start Quote Link to comment Share on other sites More sharing options...
RaananW Posted October 6, 2017 Share Posted October 6, 2017 The tsconfig in the main directory is no longer used. Gulp had its own configuration for TypeScript, for each phase and module. Gulp is the way to go. Quote Link to comment Share on other sites More sharing options...
royibernthal Posted October 8, 2017 Author Share Posted October 8, 2017 Perfect. You guys did a wonderful job there, it's very easy and convenient to modify and test bjs source. GameMonetize, Sebavan and RaananW 3 Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.