sable Posted April 21, 2018 Share Posted April 21, 2018 I've noticed that when using an action manager with sprites, both the OnPick and OnPickUp triggers are fired twice. This can be seen in the example (here), linked to from the documentation (here). Looking at the code, this seems to because scene._initClickEvent calls it's callback twice (here and here, cb being defined here). This could be solved by checking if clickInfo.ignore is true before doing all the sprite checking, unless there is a good reason this wasn't done in the first place. trevordev 1 Quote Link to comment Share on other sites More sharing options...
Sebavan Posted April 23, 2018 Share Posted April 23, 2018 Ping @trevordev Quote Link to comment Share on other sites More sharing options...
trevordev Posted April 23, 2018 Share Posted April 23, 2018 Thanks sable. That does sound like a bug and your solution seems reasonable to me. I created a PR with this change here: https://github.com/BabylonJS/Babylon.js/pull/4191 sable 1 Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.