CanvasRenderer problem

[ngc7293]

CanvasRenderer background exposure?

https://codepen.io/xf-ngc7293/pen/ExjXYrW

[ivan.popelyshev]

Hello, and Welcome to the forums

Just yesterday i was checking our sprite renderer code for canvas and found a strange thing.

I thought something is wrong with that code: https://github.com/pixijs/pixi.js/blob/f0a66e1410dd782a21fef03388b0d470f50e0d2c/packages/canvas/canvas-sprite/src/CanvasSpriteRenderer.js#L156

You can remove "floors" from it , override whole function:

 

PIXI.CanvasSpriteRenderer.prototype.render = function(sprite) { ... }

Use the same code, but remove "floors" in that drawImage.

I'll fix it next week probably

[ivan.popelyshev]

Here's your demo but on pixi-playground: https://www.pixiplayground.com/#/edit/dviwM8_okZ91hhxBDbjrg

Uncomment first line to see the fix.

I reported an issue: https://github.com/pixijs/pixi.js/issues/6447 If you want to be mentioned in subsequent PR and in next pixijs release as one of contributors - please post a comment under your github account there.

This is a good report for the first forum post!

Our community will be glad to see more content from you!

Edited February 29, 2020 by ivan.popelyshev

[ngc7293]

Thanks for your quick response.

[ivan.popelyshev]

50 minutes ago, ngc7293 said:

Thanks for your quick response.

You are right on time

1. you wrote just after i had a breakfast

2. i saw those lines of code yesterday because i made different fix (https://github.com/pixijs/pixi.js/pull/6443 )