Jump to content

Bad array iteration habits in BJS


Recommended Posts

Hi everybody,

I noticed there are numerous places in the source where for (var i in arr) is used to iterate through arrays, which is a bad habits because when a thirdparty library is modifying Array prototype (which is also a bad habits, but it happens often) that will lead to bad iteration (since it will enumerates also prototype extensions added).

Since BJS is written in TS, couldn't we just translate every for (var i in arr) { ... arr ... } to for (var elem of arr) { ... elem ... } ?

Link to comment
Share on other sites

  • 4 weeks later...

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Recently Browsing   0 members

    • No registered users viewing this page.
  • Create New...