RenderTexture border aftifact

[Borgel]

I am rendering a container to a texture.
Following this tutorial:
http://scottmcdonnell.github.io/pixi-examples/index.html?s=basics&f=render-texture.js&title=Render Texture

From what i can tell my code is identical, but i get a border spill artifact where the edge pixels on one side spills over to the other.
What could be causing this? 
The texture size is pow2 and i have tried setting different WRAP_MODES. 
 

[ivan.popelyshev]

Do texture.baseTexture.wrapMode = PIXI.WRAP_MODES.CLAMP  before you render to it. If it doesnt work, we probably have a bug, and you have to debug whether texParameter with REPEAT is called  in TextureSystem

[Borgel]

Setting the RenderTexture.baseTexture.wrapMode = PIXI.WRAP_MODES.CLAMP did not work.
I stepped through the render code and in TextureSystem.updateTextureStyle the warapMode is set to clamp (33071)
Im working in V5.2.1.

Im not very familiar with the pixi codebase, so im not sure what im looking for.
Do you have a rough idea of where you would want me to start debugging? 

[ivan.popelyshev]

if its set to clamp then it has to work. Do you use it in sprite or tilingSprite?

[Borgel]

Perhaps its not a wrapping issue? 
Sprite, not tilingSprite. 

 

var brt = new PIXI.BaseRenderTexture( 128, 128, PIXI.SCALE_MODES.LINEAR, 1 );
var rt = new PIXI.RenderTexture( brt );
var sprite = new PIXI.Sprite( rt );

rt.baseTexture.wrapMode = PIXI.WRAP_MODES.CLAMP;
renderer.wrapMode = PIXI.WRAP_MODES.CLAMP;

containerOne.addChild( sprite );
renderer.render( containerTwo, rt, true, new PIXI.Matrix().translate( x, y ) );

 

Edited October 23, 2020 by Borgel
Adding Code

[ivan.popelyshev]

btw, renderer doesnt have default wrapMode

no , it should work fine. Need more details.

[Borgel]

I tracked down the issue to a specific event.

This line:
m_graphics.beginTextureFill( { texture: t_texture, matrix: new PIXI.Matrix().translate( -m_radius, -m_height / 2 ) } );

For some reason this corrupts the texture producing the effect. 
This feels like a bug to me, but i have not had time to investigate it yet. Ill look further into it later.

Note that the effect appears both in the graphics shape and the sprite created with the texture, so it is the texture that is changed. 

[Borgel]

I have found at least where the issue is introduced, but now yet why the texture becomes corrupted. 
GraphicsGeometry -  buildDrawCalls - line 728: nextTexture.wrapMode = 10497; (repeat)
When changing this to mirror or clamp at runtime the texture corruption does not happen. 

[ivan.popelyshev]

bwahahaha, sorry, forgot about that. Yes, we force it  just change it back before it gets uploaded, or upload it by yourself first "renderer.texture.bind(myTexture)", praying that GC wont collect it and it wont be reuploaded with that forced style.

[Borgel]

Temporarily im forcing the drawcall back to clamp by intercepting 'packAttributes', as its the next function to be called after that. Super hacky, ill see about a better solution later. 

But what about the texture getting corrupted?
I can understand that the graphics object might want to tile its texture, but that should not alter the supplied texture. Surly this is a bug?

[ivan.popelyshev]

I dont remember why do we have that thing, likely @Mat Groves added it when he was adding beginTextureFill(). Maybe we had discussion about it somewhere in https://github.com/pixijs/pixi.js/issues , but i cant find it. You can create a new one

[Borgel]

Ill add a issue for it. 
I created a fiddle for the issue as well:
https://jsfiddle.net/ngutc5ob/

The blue arrow point to the graphics object that the texture is rendered to.
The black arrows point to the artifacts crated on the original texture. 
Not running beginTextureFill will leave the texture corrupted. 

 

[Borgel]

Link to the issue:
https://github.com/pixijs/pixijs/issues/6977