Jump to content

Bug report in audio module (with fix)


Recommended Posts

Hi There,


Today I was working on the new examples for the Panda.js Fiddler and noticed a small bug in the audio module.

    setMusicVolume: function(value) {        if (!game.Audio.enabled) return false;        this.musicVolume = value;        if (!this.currentMusic) return false;        if (this.context) {            this.currentMusic.gainNode.gain.value = this.musicVolume;   //ERROR!        }        else {            this.currentMusic.volume = this.musicVolume;        }        return true;    },

this.currentMusic.gainNode.gain.value = this.musicVolume;

should be: 

this.audioObjects[this.currentMusic].gainNode.gain.value = this.musicVolume;



@Enpu: Which way do you prefer to receive bugreports? (I have little experience with github yet so that's why I post this bug over here  :wacko:).



Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Recently Browsing   0 members

    • No registered users viewing this page.
  • Create New...