Apply parent of instance with .babylon file

[Pierre Glibert]

Hello people,

I had a good conversation with @JCPalmer. I asked him if he could add parent variable for instance in .babylon file and he did it.

you can read it here : 

 

At the moment, the fileloader do not apply the right parent but always the same parent of original mesh.

I will try to find solution for the babylon fileloader read parent for instance and apply this 

My idea >

Add this in mesh file :

// Instances
if (parsedMesh.instances) {
...

  if (parsedInstance.parentId) {
    instance._waitingParentId = parsedInstance.parentId;
  }

...
}

 

Because in fileLoader, this code allready exist and all instances are in "meshes" array : 

// Connect parents 
for (index = 0, cache = scene.meshes.length; index < cache; index++) {
  var mesh = scene.meshes[index];
  if (mesh._waitingParentId) {
    mesh.parent = scene.getLastEntryByID(mesh._waitingParentId);
    mesh._waitingParentId = undefined;
  }
  
  ...
}

 

What do you think @Deltakosh?

Have a nice day,

Letsbro studio team.

[Wingnut]

Hi L!  Sorry for the slow replies.  Time to bump this to the top of the list and hope for more responses.  I think everyone went water skiing or something. 

[GameMonetize]

I think this is fine.. Are you ready to submit a PR?

[Pierre Glibert]

Thanks @Wingnut and @Deltakosh for your reply. 

I will see how to contribute to Babylon very soon and submit this update

 

[Pierre Glibert]

Hi everyone,

This correction is done