V!nc3r

Default Rendering Pipeline and colorGrading

Recommended Posts

OK, very nice, thanks!

I don't find your tips in the doc', am I missing something? Should probably be here I think: http://doc.babylonjs.com/how_to/how_to_use_postprocesses#imageprocessing

The associated colorGrading playground actually use this 3dl texture, could be a nice idea to give also an example with png, what do you think?

 

Share this post


Link to post
Share on other sites

PR done.

I notice we get some edge-detection-artefacts when increasing the default contrast, example: https://www.babylonjs-playground.com/#K4S3GU#28

j9wQcl9.png

But these artefacts aren't here when I tweak the LUT from Photoshop. Is it another properties combination where I'm wrong? 😵

[edit] is it have something to deal with mipmaps? (even if noMipmaps is set to true?)

Share this post


Link to post
Share on other sites

hmm, yep, me again, sorry if I bored you ahah.

I've still the bug, in this test scene for example: https://www.babylonjs-playground.com/#XYK7JG#1 with - I think- all the tweaks you told me, and using pipeline.

1GS3IGl.png

Make some test on our usual thread playground with kind-of same settings : https://www.babylonjs-playground.com/#K4S3GU#32 and here, all works fine.

[edit: woops, actually artefact spotted! NMBiPK5.png /edit]

I tryied to understand from where the issue comes in the cornell box playground, and the only thing I found but don't understand why is that these artefacts disappear when I comment the light creation (line 10) https://www.babylonjs-playground.com/#XYK7JG#2

Have we something clamped somewhere, and another setting to add to the doc' ? :)

Share this post


Link to post
Share on other sites

I am wondering if it is not related to of the colors are mapped in the LUT.

Could you try a sdl file instead ? On webgl2 browsers this would be blazing fast as it would rely on 3d texture and interpolations would not be an issue anymore.

Share this post


Link to post
Share on other sites

So, I tried with a .3dl. (didn't know until now that Photoshop allowing exporting this, thanks for the discorvery :))

But, some colors looks inverted:

qnu4Gwo.gif

Here my process in video: https://www.dropbox.com/s/fce6bj1ho7xvohf/photoshop-LUT-exporting.mp4?dl=0

I6KEPlv.png

And, of course, the playground: https://www.babylonjs-playground.com/#K4S3GU#35

and my .3dl direct link., compared to the BJS one online, I don't know if something is wrong here:

Fze3t2U.png

I tried playing with the colorGradingWithGreenDepth things, same issue. But at least, no artefacts... just wrong colors :D

(I think the doc' will be updated soon after all that things fixed ahah)

 

Share this post


Link to post
Share on other sites
9 hours ago, Sebavan said:

@V!nc3r or @PatrickRyan Could you please export an identity 3dl for me ? 

This would be the easiest to test the setup.

@Sebavan here is your identity LUT if you still need one. I am starting a repo for LUTs for us to use/share. Yours is the first.

https://github.com/PatrickRyanMS/BabylonJStextures/tree/master/LUT 

or if you just want the raw link to include in your PG:

https://raw.githubusercontent.com/PatrickRyanMS/BabylonJStextures/master/LUT/NoAdjustment.3DL

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Loading...

  • Recently Browsing   0 members

    No registered users viewing this page.